Changed import of AWS - reduce code size #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled out the S3 dependency, and imported AWS directly from aws-sdk/global
|
@sean9keenan Nice work! This is something we should add to the tutorial. Did you find any documentation for this on AWS' side? We'd want to link to that in the tutorial as well. |
|
@sean9keenan Great! Thanks. I'll take a look and figure out how to integrate it with the tutorial. |
|
thx @sean9keenan |
|
@sean9keenan I added a section in the Deploy chapter on your PR and linked to it as well - https://serverless-stack.com/chapters/deploy-to-s3.html#app-bundle-size Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out the S3 dependency, and imported AWS directly from aws-sdk/global.
This makes it possible for webpack to minimize the AWS SDK as the other dependencies don't even enter the picture.
The net impact for me was reducing the javascript file that is downloaded from 1.9MB to 788KB, which was a pretty big win in my book! (Specifically the
aws-sdkis now 216KB vs 1.3MB)Although I'll be honest - it took me longer than I care to admit to find this particular incantation to reduce the bundle size... 😄
For future people that might read this:
import { Config, CognitoIdentityCredentials } from 'aws-sdk'. Completely works - you just have to pass theConfigmanually into the second arg ofCognitoIdentityCredentials, as well as change the region on the config directly as a property, but alas this doesn't let Webpack minimize the sdk properly.